Skip to content

Trim slash for configure URL.#2381

Merged
TingluoHuang merged 1 commit intomasterfrom
users/tihuang/fixslash
Mar 9, 2023
Merged

Trim slash for configure URL.#2381
TingluoHuang merged 1 commit intomasterfrom
users/tihuang/fixslash

Conversation

@TingluoHuang
Copy link
Copy Markdown
Member

We get 404 errors when making API request to api.github.com with the URL ending with a /, ex: https://github.com/test/

https://github.com/github/c2c-actions-runtime/issues/2367

Copy link
Copy Markdown
Member

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@TingluoHuang TingluoHuang merged commit a462ecb into master Mar 9, 2023
@TingluoHuang TingluoHuang deleted the users/tihuang/fixslash branch March 9, 2023 14:02
@rentziass rentziass mentioned this pull request Mar 10, 2023
unpollito pushed a commit to DistruApp/actions-runner-controller that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants