Trim repo/org/enterprise to 63 characters in label values#2657
Merged
nikola-jokic merged 2 commits intomasterfrom Jun 9, 2023
Merged
Trim repo/org/enterprise to 63 characters in label values#2657nikola-jokic merged 2 commits intomasterfrom
nikola-jokic merged 2 commits intomasterfrom
Conversation
TingluoHuang
reviewed
Jun 9, 2023
|
|
||
| const trimLabelVauleSuffix = "-trim" | ||
|
|
||
| func trimLabelValue(val string) string { |
Member
There was a problem hiding this comment.
do we have anything else need to trim? both in code and helm chart, might worth to double check all labels on an installed ARC.
Collaborator
Author
There was a problem hiding this comment.
I'll test it 😄
TingluoHuang
approved these changes
Jun 9, 2023
Merged
unpollito
pushed a commit
to DistruApp/actions-runner-controller
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.