Fix overscaling when the controller is much faster then the listener#3371
Merged
nikola-jokic merged 6 commits intomasterfrom Mar 20, 2024
Merged
Fix overscaling when the controller is much faster then the listener#3371nikola-jokic merged 6 commits intomasterfrom
nikola-jokic merged 6 commits intomasterfrom
Conversation
nikola-jokic
requested review from
a team,
mumoshu,
rentziass and
toast-gear
as code owners
nikola-jokic
added
the
gha-runner-scale-set
rentziass
previously approved these changes
Mar 20, 2024
Member
rentziass
left a comment
rentziass
left a comment
There was a problem hiding this comment.
This looks good to me, I just left a bunch of suggestions over a type!
Co-authored-by: Francesco Renzi <rentziass@gmail.com>
rentziass
approved these changes
Mar 20, 2024
Merged
Closed
4 tasks
unpollito
pushed a commit
to DistruApp/actions-runner-controller
that referenced
this pull request
Jan 21, 2026
…ctions#3371) Co-authored-by: Francesco Renzi <rentziass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ephemeral runner finishes, the listener issues a scale-down patch to the ephemeral runner set. But if ephemeral runner set reacts quicker than the listener, it may re-create the ephemeral runner, and quickly remove it.
To avoid this problem, this PR introduces the following changes:
This change also requires a change in the CRD.