Issue #1472 suggested fix#1474
Merged
scarroll32 merged 7 commits intoactiverecord-hackery:mainfrom Sep 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorders the conditional checks in the method_missing method to prioritize allowlisted ransackable_scopes over regular attribute methods, addressing issue #1472. This change allows developers to explicitly allowlist scopes without needing to monkey patch gem-related models.
- Reordered conditional logic to check
ransackable_scope?beforeattribute_method? - Maintained existing functionality while changing execution priority
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
scarroll32
added a commit
that referenced
this pull request
Sep 24, 2025
This reverts commit dcb57c5.
scarroll32
added a commit
that referenced
this pull request
Sep 24, 2025
This reverts commit dcb57c5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #1472
This will allow developers to allowlist
ransackable_scopesahead of regular non-allowlisted attributed ransack searches. This helps avoid needing to monkey patch gem-related models and give developers explicit ability to say "this is scope is good".