Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
* Fix a wrong link in `CHANGELOG.md`.
PR [1323](https://github.com/activerecord-hackery/ransack/pull/1323)

* Fix links to bug report templates in `CONTRIBUTING.md`.
* Update `CONTRIBUTING.md` to encourage failing tests in PRs instead of bug report templates.
PR [1321](https://github.com/activerecord-hackery/ransack/pull/1321)

## 3.2.0 - 2022-05-08
Expand Down Expand Up @@ -240,7 +240,7 @@
* Enable RuboCop and configure GitHub Actions to run RuboCop by @yahonda in https://github.com/activerecord-hackery/ransack/pull/1185
* Add Ruby 3.0.0 support by @yahonda in https://github.com/activerecord-hackery/ransack/pull/1190
* Drop Ruby 2.5 or older versions of Ruby by @yahonda in https://github.com/activerecord-hackery/ransack/pull/1189
* Move bug report templates into ransack repository and run templates at CI by @yahonda in https://github.com/activerecord-hackery/ransack/pull/1191
* Remove bug report templates and encourage failing tests in PRs instead by @yahonda in https://github.com/activerecord-hackery/ransack/pull/1191
* Allow Ransack to be tested with Rails main branch by @yahonda in https://github.com/activerecord-hackery/ransack/pull/1192

## 2.4.1 - 2020-12-21
Expand Down
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ Steps:
3. **Isolate the real problem** — make sure the issue is really a bug in
Ransack and not in your code or another gem.

4. **Report the issue** by providing the link to a self-contained
gist like [this](https://github.com/activerecord-hackery/ransack/blob/main/bug_report_templates/test-ransack-scope-and-column-same-name.rb) or
[this](https://github.com/activerecord-hackery/ransack/blob/main/bug_report_templates/test-ransacker-arel-present-predicate.rb). Please use
these code examples as a bug-report template for your Ransack issue!
4. **Create a failing test** by writing a test that demonstrates the issue. You can:
- Copy and modify an existing test from the test suite
- Create a new test file following the existing patterns
- Submit a pull request with your failing test

If you do not provide a self-contained gist and would like your issue to be reviewed, do provide at a minimum:
If you do not provide a failing test and would like your issue to be reviewed, do provide at a minimum:

* A comprehensive list of steps to reproduce the issue, or even better, a
passing/failing test spec.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ This [gist](https://gist.github.com/raghubetina/d5fc3df67ddbadcac271) has a quic

* Before filing an issue, please read the [Contributing Guide](CONTRIBUTING.md).
* File an issue if a bug is caused by Ransack, is new (has not already been reported), and _can be reproduced from the information you provide_.
* Please consider adding a branch with a failing spec describing the problem.
* Please consider creating a pull request with a failing test that demonstrates the problem.
* Contributions are welcome. :smiley:
* Please do not use the issue tracker for personal support requests. Stack Overflow or [GitHub Discussions](https://github.com/activerecord-hackery/ransack/discussions) is a better place for that where a wider community can help you!

Expand Down
78 changes: 0 additions & 78 deletions bug_report_templates/test-ransack-scope-and-column-same-name.rb

This file was deleted.

75 changes: 0 additions & 75 deletions bug_report_templates/test-ransacker-arel-present-predicate.rb

This file was deleted.

2 changes: 1 addition & 1 deletion docs/docs/intro.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ The [Ransack Demo application](https://github.com/activerecord-hackery/ransack_d

* Before filing an issue, please read the [Contributing Guide](https://github.com/activerecord-hackery/ransack/CONTRIBUTING.md).
* File an issue if a bug is caused by Ransack, is new (has not already been reported), and _can be reproduced from the information you provide_.
* Please consider adding a branch with a failing spec describing the problem.
* Please consider creating a pull request with a failing test that demonstrates the problem.
* Contributions are welcome. :smiley:
* Please do not use the issue tracker for personal support requests. Stack Overflow is a better place for that where a wider community can help you!

Expand Down
Loading