-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: usb_cdc.Serial.readinto has no nbytes parameter #6944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build failure in build-doc is:
|
Wow that has to come from a sphinx related update, I didn't get that locally.
Which is super useful.
These are generated files, so: //| @property
//| def writing(self) -> bool:
//| """Returns True if a background write is in progress"""
//| Becomes: .. method:: writing(self) -> bool
:property:
Returns True if a background write is in progress I would change it to: //| writing: bool
//| """Returns True if a background write is in progress"""
//| I can add those changes to this PR, but I get another error in the template, due to sphinx version, I'm curious to see if the CI gets it too. |
Ok this time the CI does give the same error I get locally:
This is a sphinx-rtd-theme issue: We can temporarily set the sphinx version to 5.1.1 |
Mind adding that to this PR? If you do please tag me for reviewing. |
Pushed the workaround:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this finally builds it's good to merge. I added the 3.10.6 python pin for the doc build
Thanks! |
And returns int.