fix(rabbit): handle leading slash in virtualhost correctly #2707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the leading slash was unconditionally stripped from the virtualhost argument. This caused a regression where vhosts named '/name' were incorrectly parsed as 'name'. This commit fixes the parsing logic to preserve the leading slash while maintaining backward compatibility for the '//name' workaround. Fixes ag2ai#2652
|
|
Lancetnik
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the leading slash was unconditionally stripped from the
virtualhostargument. This caused a regression where vhosts named/namewere incorrectly parsed asname.This PR restores backward compatibility with version 0.5.33. Now a leading slash in
virtualhost(e.g./test) is preserved correctly.Fixes #2652
Type of change
Checklist
just lintshows no errors)just test-coveragejust static-analysis