fix: handle missing 'type' field in tool parameter properties for OpenAITokenCounter#1403
Open
octo-patch wants to merge 1 commit intoagentscope-ai:mainfrom
Open
Conversation
…en counter (fixes agentscope-ai#1397) When PlanNotebook is enabled, some plan-related tools may have parameter properties without a 'type' field, causing a KeyError in _calculate_tokens_for_tools. Use .get('type', '') instead of direct key access to handle this gracefully.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1397
Problem
When
PlanNotebookis enabled, some plan-related tools (e.g.,view_historical_plans) define parameter properties that do not include atypefield. The_calculate_tokens_for_toolsfunction in_openai_token_counter.pyattempts to accessproperties[key]["type"]directly, causing aKeyErrorwhen the field is absent.Solution
Replace the direct key access
properties[key]["type"]withproperties[key].get("type", "")so that missingtypefields are handled gracefully with an empty string fallback, which is safe to encode and contributes 0 extra tokens.Testing
Manually verified: constructing a tool schema where a property omits the
typefield (as in theview_historical_plansplan tool) no longer raises aKeyErrorwhen token counting is invoked.