fix: allow DocMetadata to accept extra keyword arguments from stored payloads#1404
Open
octo-patch wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix: allow DocMetadata to accept extra keyword arguments from stored payloads#1404octo-patch wants to merge 1 commit intoagentscope-ai:mainfrom
octo-patch wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
…payloads (fixes agentscope-ai#1374) When users add custom fields (e.g. 'filename') to document metadata and store them in Qdrant, retrieving the documents fails with: TypeError: DocMetadata.__init__() got an unexpected keyword argument 'filename' Use @DataClass(init=False) with a custom __init__ that accepts **kwargs and sets extra fields as attributes, preserving user-defined metadata.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1374
Problem
When users add custom fields (e.g.
filename) to document metadata before storing documents in Qdrant, retrieving those documents fails with:This happens because
DocMetadata(**point.payload)is called in_qdrant_store.pyduring retrieval, butDocMetadataonly accepts its four defined fields and rejects any extra keyword arguments.Solution
Change
DocMetadatato use@dataclass(init=False)and define a custom__init__that accepts**kwargs. Any extra fields are stored as instance attributes viasetattr, preserving user-defined metadata and making it accessible after retrieval.Testing
Manually verified: after setting a custom
filenameattribute onDocMetadataand storing a document, callingknowledge.retrieve()no longer raises aTypeErrorand thefilenameattribute is accessible on the returned document's metadata.