-
Notifications
You must be signed in to change notification settings - Fork 44
Reenable Windows tests #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 12 12
Lines 681 681
Branches 80 80
=======================================
Hits 561 561
Misses 102 102
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@samuelcolvin Have you got any time to check out this error? Seems grablib fails with a |
@samuelcolvin Also, do you have admin access? I'd like pyup removed and the required status set on the 3.9 tests (otherwise Dependabot will auto-merge broken dependencies). |
Thanks, I'll try to look next week. |
@Dreamsorcerer I've made you an admin. I'll look at grablib now. |
@Dreamsorcerer please please can you use informative names for branches in github. Couldn't be less helpful |
as explained here windows tests were passing when they shouldn't be. |
Seems the problem is only deprecation warnings internal to python (which is a result of a change I got merged into the last 3.9 release). Looks like everything is running now after your previous change. Though curious the warnings didn't fail the tests for ubuntu/mac. |
Also, I don't see any setting for pyup. Is it managed at https://pyup.io/? Would be nice to disable it, as dependabot should be working and auto-merging. |
I deleted the webhooks. |
Still seem to be coming in for some reason: |
No description provided.