Skip to content

Reenable Windows tests #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2021
Merged

Reenable Windows tests #329

merged 6 commits into from
Sep 12, 2021

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #329 (07439a0) into master (88b7477) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files          12       12           
  Lines         681      681           
  Branches       80       80           
=======================================
  Hits          561      561           
  Misses        102      102           
  Partials       18       18           
Flag Coverage Δ
unit 82.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b7477...07439a0. Read the comment docs.

@Dreamsorcerer
Copy link
Member Author

@samuelcolvin Have you got any time to check out this error? Seems grablib fails with a UnicodeEncodeError on Windows (although the exception itself seems to come from click).

@Dreamsorcerer
Copy link
Member Author

@samuelcolvin Also, do you have admin access? I'd like pyup removed and the required status set on the 3.9 tests (otherwise Dependabot will auto-merge broken dependencies).

@samuelcolvin
Copy link
Member

Thanks, I'll try to look next week.

@samuelcolvin
Copy link
Member

@Dreamsorcerer I've made you an admin. I'll look at grablib now.

@samuelcolvin
Copy link
Member

@Dreamsorcerer please please can you use informative names for branches in github.

image

Couldn't be less helpful

@samuelcolvin
Copy link
Member

as explained here windows tests were passing when they shouldn't be.

@Dreamsorcerer
Copy link
Member Author

Seems the problem is only deprecation warnings internal to python (which is a result of a change I got merged into the last 3.9 release). Looks like everything is running now after your previous change.

Though curious the warnings didn't fail the tests for ubuntu/mac.

@Dreamsorcerer Dreamsorcerer merged commit 659056f into master Sep 12, 2021
@Dreamsorcerer
Copy link
Member Author

Also, I don't see any setting for pyup. Is it managed at https://pyup.io/? Would be nice to disable it, as dependabot should be working and auto-merging.

@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-5 branch September 12, 2021 19:36
@samuelcolvin
Copy link
Member

I deleted the webhooks.

@Dreamsorcerer
Copy link
Member Author

I deleted the webhooks.

Still seem to be coming in for some reason:
#337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants