Check multipart max_size during iteration by Dreamsorcerer · Pull Request #12216 · aio-libs/aiohttp

Dreamsorcerer · 2026-03-07T19:19:14Z

No description provided.

aiohttp/web_request.py

codecov · 2026-03-07T19:28:08Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
4405	1	4404	46

View the top 1 failed test(s) by shortest run time

tests.test_web_functional::test_app_max_client_size_form_decode[pyloop]

Stack Traces | 0.161s run time

aiohttp_client = <function aiohttp_client.<locals>.go at 0x7fcf4705bd00>

    #x1B[0m#x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m#x1B[90m #x1B[39;49;00m#x1B[92mtest_app_max_client_size_form_decode#x1B[39;49;00m(aiohttp_client: AiohttpClient) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        #x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m#x1B[90m #x1B[39;49;00m#x1B[92mhandler#x1B[39;49;00m(request: web.Request) -> NoReturn:#x1B[90m#x1B[39;49;00m
            #x1B[94mawait#x1B[39;49;00m request.post()#x1B[90m#x1B[39;49;00m
            #x1B[94massert#x1B[39;49;00m #x1B[94mFalse#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
        app = web.Application()#x1B[90m#x1B[39;49;00m
        app.router.add_post(#x1B[33m"#x1B[39;49;00m#x1B[33m/#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, handler)#x1B[90m#x1B[39;49;00m
        client = #x1B[94mawait#x1B[39;49;00m aiohttp_client(app)#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
        #x1B[94mwith#x1B[39;49;00m aiohttp.MultipartWriter(#x1B[33m"#x1B[39;49;00m#x1B[33mform-data#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m) #x1B[94mas#x1B[39;49;00m mp:#x1B[90m#x1B[39;49;00m
            #x1B[90m# Verify that entire multipart form can't exceed client size (not just each field).#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
            #x1B[94mfor#x1B[39;49;00m i #x1B[95min#x1B[39;49;00m #x1B[96mrange#x1B[39;49;00m(#x1B[94m3#x1B[39;49;00m):#x1B[90m#x1B[39;49;00m
                part = mp.append(gzip.compress(#x1B[33mb#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33mA#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m * #x1B[94m512000#x1B[39;49;00m))#x1B[90m#x1B[39;49;00m
                part.set_content_disposition(#x1B[33m"#x1B[39;49;00m#x1B[33mform-data#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, name=#x1B[33mf#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33mf#x1B[39;49;00m#x1B[33m{#x1B[39;49;00mi#x1B[33m}#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
                part.headers[CONTENT_ENCODING] = #x1B[33m"#x1B[39;49;00m#x1B[33mgzip#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
            #x1B[94masync#x1B[39;49;00m #x1B[94mwith#x1B[39;49;00m client.post(#x1B[33m"#x1B[39;49;00m#x1B[33m/#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, data=mp) #x1B[94mas#x1B[39;49;00m resp:#x1B[90m#x1B[39;49;00m
>               #x1B[94massert#x1B[39;49;00m resp.status == #x1B[94m413#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE               AssertionError: assert 500 == 413#x1B[0m
#x1B[1m#x1B[31mE                +  where 500 = <ClientResponse(http://127.0.0.1:42375/) [500 Internal Server Error]>\n<CIMultiDictProxy('Content-Type': 'text/plain; charset=utf-8', 'Content-Length': '55', 'Date': 'Mon, 09 Mar 2026 02:20:42 GMT', 'Server': 'Python/3.10 aiohttp/4.0.0a2.dev0', 'Connection': 'close')>\n.status#x1B[0m

aiohttp_client = <function aiohttp_client.<locals>.go at 0x7fcf4705bd00>
app        = <Application 0x7fcf46bc8930>
client     = <aiohttp.test_utils.TestClient object at 0x7fcf4762af50>
handler    = <function test_app_max_client_size_form_decode.<locals>.handler at 0x7fcf47f1da20>
i          = 2
mp         = <aiohttp.multipart.MultipartWriter object at 0x7fcf4762a440>
part       = <aiohttp.payload.BytesPayload object at 0x7fcf4762b040>
resp       = <ClientResponse(http://127.0.0.1:42375/) [500 Internal Server Error]>
<CIMultiDictProxy('Content-Type': 'text/plain; c...: '55', 'Date': 'Mon, 09 Mar 2026 02:20:42 GMT', 'Server': 'Python/3.10 aiohttp/4.0.0a2.dev0', 'Connection': 'close')>


#x1B[1m#x1B[31mtests/test_web_functional.py#x1B[0m:1726: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

codspeed-hq · 2026-03-07T19:36:40Z

Merging this PR will not alter performance

✅ 59 untouched benchmarks

_{Comparing check-multipart-length (9237cda) with master (5fe9dfb)}

aiohttp/web_request.py

for more information, see https://pre-commit.ci

aiohttp/web_request.py

tests/test_web_functional.py

bdraco · 2026-03-10T01:40:07Z

So PR seems correct as-is. The test is just failing because it doesn't decompress, which is correct. It just needs a real large payload to trigger the production. The bytes/bytearray type issues should probably get ignores and be solved in a future PR.

patchback · 2026-03-10T20:59:25Z

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/9cc4b917c54833a22f65edae7963d16a6eeb1f54/pr-12216

Backported as #12229

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

(cherry picked from commit 9cc4b91)

patchback · 2026-03-10T21:00:09Z

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/9cc4b917c54833a22f65edae7963d16a6eeb1f54/pr-12216

Backported as #12230

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

(cherry picked from commit 9cc4b91)

…teration (#12230) **This is a backport of PR #12216 as merged into master (9cc4b91).** --------- Co-authored-by: Sam Bull <git@sambull.org>

…teration (#12229) **This is a backport of PR #12216 as merged into master (9cc4b91).** --------- Co-authored-by: Sam Bull <git@sambull.org>

…during iteration (aio-libs#12230) **This is a backport of PR aio-libs#12216 as merged into master (9cc4b91).** --------- Co-authored-by: Sam Bull <git@sambull.org>

…during iteration (aio-libs#12229) **This is a backport of PR aio-libs#12216 as merged into master (9cc4b91).** --------- Co-authored-by: Sam Bull <git@sambull.org>

Check multipart max_size during iteration

a6cffda

Dreamsorcerer requested a review from asvetlov as a code owner March 7, 2026 19:19

Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Mar 7, 2026

Dreamsorcerer commented Mar 7, 2026

View reviewed changes

aiohttp/web_request.py Outdated Show resolved Hide resolved

Apply suggestion from @Dreamsorcerer

ff580fb

Dreamsorcerer commented Mar 7, 2026

View reviewed changes

aiohttp/web_request.py Outdated Show resolved Hide resolved

Dreamsorcerer added 2 commits March 7, 2026 19:20

Apply suggestion from @Dreamsorcerer

1fcd169

Update web_request.py

82f3c57

Update web_request.py

5f491e1

Dreamsorcerer commented Mar 8, 2026

View reviewed changes

aiohttp/web_request.py Show resolved Hide resolved

Dreamsorcerer and others added 6 commits March 8, 2026 23:19

Apply suggestion from @Dreamsorcerer

db76b70

Update test_web_functional.py

6c7237a

Update test_web_functional.py

9b4b43d

Update test_web_functional.py

4e44025

Update test_web_functional.py

b76c8c1

[pre-commit.ci] auto fixes from pre-commit.com hooks

d25afee

for more information, see https://pre-commit.ci

bdraco reviewed Mar 10, 2026

View reviewed changes

aiohttp/web_request.py Outdated Show resolved Hide resolved

bdraco reviewed Mar 10, 2026

View reviewed changes

aiohttp/web_request.py Show resolved Hide resolved

bdraco approved these changes Mar 10, 2026

View reviewed changes

bdraco reviewed Mar 10, 2026

View reviewed changes

tests/test_web_functional.py Outdated Show resolved Hide resolved

Dreamsorcerer added 3 commits March 10, 2026 20:22

Update web_request.py

62ad6b6

Update test_web_functional.py

ab24e1e

Update web_request.py

9237cda

Dreamsorcerer merged commit 9cc4b91 into master Mar 10, 2026
43 checks passed

Dreamsorcerer deleted the check-multipart-length branch March 10, 2026 20:59

patchback bot pushed a commit that referenced this pull request Mar 10, 2026

Check multipart max_size during iteration (#12216)

b851d14

(cherry picked from commit 9cc4b91)

patchback bot mentioned this pull request Mar 10, 2026

[PR #12216/9cc4b917 backport][3.13] Check multipart max_size during iteration #12229

Merged

patchback bot pushed a commit that referenced this pull request Mar 10, 2026

Check multipart max_size during iteration (#12216)

fa4dd54

(cherry picked from commit 9cc4b91)

patchback bot mentioned this pull request Mar 10, 2026

[PR #12216/9cc4b917 backport][3.14] Check multipart max_size during iteration #12230

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Check multipart max_size during iteration#12216

Check multipart max_size during iteration#12216
Dreamsorcerer merged 14 commits intomasterfrom
check-multipart-length

Dreamsorcerer commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdraco commented Mar 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

patchback bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

patchback bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Dreamsorcerer commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

codspeed-hq bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdraco commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

patchback bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to 3.13: 💚 backport PR created

Uh oh!

patchback bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backport to 3.14: 💚 backport PR created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Mar 7, 2026 •

edited

Loading

codspeed-hq bot commented Mar 7, 2026 •

edited

Loading

bdraco commented Mar 10, 2026 •

edited

Loading

patchback bot commented Mar 10, 2026 •

edited

Loading

patchback bot commented Mar 10, 2026 •

edited

Loading