Fixes warning when inserting binary strings#326
Merged
terricain merged 1 commit intoaio-libs:masterfrom Jul 31, 2018
terricain:issue_323
Merged
Fixes warning when inserting binary strings#326terricain merged 1 commit intoaio-libs:masterfrom terricain:issue_323
terricain merged 1 commit intoaio-libs:masterfrom
terricain:issue_323
Conversation
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 9 9
Lines 1129 1129
Branches 161 161
=======================================
Hits 1049 1049
Misses 56 56
Partials 24 24Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
Inserting a binary object it raises a warning, this fixes it. Inspiration taken from PyMySQL/mysqlclient#106
@jettify review please. I don't think it will cause any adverse effects.