Merged
Conversation
elBroom
force-pushed
the
master
branch
3 times, most recently
from
59e9006 to
b9684b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 92.28% 92.28% +<.01%
==========================================
Files 9 9
Lines 1179 1180 +1
Branches 172 172
==========================================
+ Hits 1088 1089 +1
Misses 64 64
Partials 27 27
Continue to review full report at Codecov.
|
terricain
reviewed
Jan 17, 2019
Collaborator
terricain
left a comment
terricain
left a comment
There was a problem hiding this comment.
Other than that, looks ok to me, doesn't look like it'll break any compatibility.
aiomysql/sa/engine.py
Outdated
| The pool has *minsize* opened connections to PostgreSQL server. | ||
| The pool has *minsize* opened connections to mysql server. | ||
| """ | ||
| deplecated_cursor_classes = [ |
Collaborator
There was a problem hiding this comment.
Shouldn't deplecated be deprecated?
Contributor
Author
There was a problem hiding this comment.
yes, it's a mistake
aiomysql/sa/engine.py
Outdated
| Returns Engine instance with embedded connection pool. | ||
|
|
||
| The pool has *minsize* opened connections to PostgreSQL server. | ||
| The pool has *minsize* opened connections to mysql server. |
Collaborator
There was a problem hiding this comment.
MySQL not mysql, might as well include the capitals
elBroom
force-pushed
the
master
branch
2 times, most recently
from
3783562 to
313d221
Compare
terricain
approved these changes
Jan 20, 2019
Collaborator
|
Cool, looks good thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #373