remove unnecessary var from numerator and denominator in geometic equation and tidy up /algorithm code#281
Open
albertstill wants to merge 4 commits into
Open
remove unnecessary var from numerator and denominator in geometic equation and tidy up /algorithm code#281albertstill wants to merge 4 commits into
albertstill wants to merge 4 commits into
Conversation
Contributor
Author
|
Can we merge this now? |
Contributor
Author
|
What about now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an unnecessary var being used in the geometric equation, I've removed it and tidied up the code. Note there are tests to cover the geometric equation, them passing helps prove it's the same equation with this var removed.
Here is some handwritten maths explaining why the
maxneed not live at the top and bottom of the fraction, it just cancels out. I start with what we used to have and finish with what this PR changes to.