[slider] Add aria-label to Slider#286
Open
richardgreg wants to merge 1 commit into
Open
Conversation
Fixes airbnb#273 Signed-off-by: Richard Gregory <richardgrecoson@gmail.com>
richardgreg
force-pushed
the
aria-label-slider-fix
branch
from
2628ecd to
8ff60ce
Compare
ljharb
requested changes
Mar 31, 2022
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thanks - this needs tests before it could be added, and should be added to docs as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273
Signed-off-by: Richard Gregory richardgrecoson@gmail.com