Deleting SurveyInstance fails if a summaried answer is > 1500 chars

[stellanl]

In SurveyInstanceDAO, L578:

akvo-flow/GAE/src/org/waterforpeople/mapping/dao/SurveyInstanceDAO.java

Lines 578 to 579 in cce3c3a

	List<SurveyQuestionSummary> summaryList = summDao.listByResponse(
	qasItem.getQuestionID(), qasItem.getValue());

it is possible for qasItem.getValue() to return > 1500 chars, but summDao.listByResponse() cannot handle that:

java.lang.IllegalArgumentException: response: String properties must be 1500 bytes or less. Instead, use com.google.appengine.api.datastore.Text, which can store strings of any length. at org.datanucleus.api.jdo.NucleusJDOHelper.getJDOExceptionForNucleusException(NucleusJDOHelper.java:488) at org.datanucleus.api.jdo.JDOQuery.executeWithMap(JDOQuery.java:351) at org.waterforpeople.mapping.analytics.dao.SurveyQuestionSummaryDao.listByResponse(SurveyQuestionSummaryDao.java:158) at org.waterforpeople.mapping.dao.SurveyInstanceDAO.deleteSurveyInstance(SurveyInstanceDAO.java:578) at org.waterforpeople.mapping.app.web.rest.SurveyInstanceRestService.deleteSurveyInstanceById(SurveyInstanceRestService.java:243)

[stellanl]

Question 2830060031, an OPTION, has very long option names, and allows multiple answers. Almost all answers for it are>1500 chars long. (Stored in the valueText field.)

[stellanl]

Constants.MAX_LENGHT is 500, although the Datastore limit for persistable (indexable) String is 1500. Is this an old value, or were they just being very cautious? Maybe time to increase it?

[stellanl]

The SurveyInstanceDAO.deleteSurveyInstance() summaries-adjusting code does not handle JSON answers at all, so many, if not all, negative adjustments have been getting lost for some time.

[stellanl]

I can find nothing that prevents creating an option text longer than 1500 chars.
Trying to create one fails silently (for the user).
There should be a limit in the UI. I suggest setting it to 500 like for the question text.

[muloem]

Constants.MAX_LENGHT is 500, although the Datastore limit for persistable (indexable) String is 1500. Is this an old value, or were they just being very cautious? Maybe time to increase it?

@stellanl yes the value used to be capped at 500xters and was probably recently increased.

[muloem]

I can find nothing that prevents creating an option text longer than 1500 chars.
Trying to create one fails silently.
There should be a limit in the UI. I suggest setting it to 500 like for the question text.

I believe it was setup in such a way that for responses greater than the limit, they were stored in a Text type field (valueText)