Don't create directories before we've verified they're inside the tar… #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
dignifiedquire
added a commit
to dignifiedquire/async-tar
that referenced
this pull request
Aug 23, 2021
dignifiedquire
added a commit
to dignifiedquire/async-tar
that referenced
this pull request
Aug 24, 2021
* fix: do not create directories outside ports alexcrichton/tar-rs#259 * fixups
This was referenced Feb 2, 2025
charliermarsh
added a commit
to astral-sh/tokio-tar
that referenced
this pull request
Feb 2, 2025
## Summary This is a port of alexcrichton/tar-rs#259 which was later ported to `async-tar` in dignifiedquire/async-tar#24. The goal is to avoid allowing archives to create directories outside of the target path by deferring the creation of directories. ## Test Plan `cargo test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexcrichton @rocallahan this a resubmission of #258 with the rustfmt error fixed. (Sorry, we're a bit impatient to get a new release of tar with this fixed!)