fix(specs): remove baseRecommendRequest from trendingFacets [CR-10264]#5858
Merged
fix(specs): remove baseRecommendRequest from trendingFacets [CR-10264]#5858
Conversation
Collaborator
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
raed667
changed the title
Contributor
Author
|
IMO not a breaking change, more of a bug fix to correct the usage, the API would throw anyway if you passed these params |
Collaborator
|
@raed667 yeah, I get your point It's understandable if it's a fix though |
Fluf22
approved these changes
Jan 23, 2026
Collaborator
Fluf22
left a comment
Fluf22
left a comment
There was a problem hiding this comment.
Let's not forget to add a breaking change notice to the changelog
algolia-bot
added a commit
that referenced
this pull request
Jan 23, 2026
#5858) (generated) [skip ci] Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Jan 23, 2026
…] (generated) algolia/api-clients-automation#5858 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Recommend trending-facets query doesn't have a lot in common with Recommend base query. It is easier and less error prone to manage it separately.
In practice this PR removes
queryParameters&fallbackParametersfrom trending facets query.