Skip to content

Replace moment with dayjs#1

Merged
farnabaz merged 5 commits intomasterfrom
dayjs
Sep 5, 2018
Merged

Replace moment with dayjs#1
farnabaz merged 5 commits intomasterfrom
dayjs

Conversation

@farnabaz
Copy link
Copy Markdown
Member

@farnabaz farnabaz commented Sep 4, 2018

No description provided.

Comment thread demo/pages/index.vue Outdated
import moment from 'moment';

import { VuecRangeInput, VuecSingleInput } from '../../src';
import date from '../../src/date';
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ~

Comment thread package.json Outdated
@@ -1,11 +1,11 @@
{
"name": "vuec",
"name": "@alibaba-aero/vuec",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: We should deprecate old package

Comment thread src/components/core/default-day.vue Outdated

<script>
import { formatDate } from '../../utils';
// import { formatDate } from '../../utils';
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment thread src/components/core/default-day.vue Outdated
computed: {
formattedDate() {
return formatDate(this.date, 'jD', true);
return this.date.format('D'); // formatDate(this.date, 'D', true);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@farnabaz farnabaz merged commit bc854ec into master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants