Skip to content

Enable ephemeral containers #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

GlassOfWhiskey
Copy link
Member

No description provided.

)
return await self.connector.run(
location=location if self.ephemeral else get_inner_location(location),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
location=location if self.ephemeral else get_inner_location(location),
location=get_inner_location(location),

)
# Populate instance
await self._populate_instance(self.instanceName)
sif_exists = returncode == 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sif_exists = returncode == 1
sif_exists = returncode == 0

@GlassOfWhiskey GlassOfWhiskey force-pushed the ephemeral-containers branch 12 times, most recently from ff31760 to 926fc89 Compare November 17, 2024 19:24
@GlassOfWhiskey GlassOfWhiskey force-pushed the ephemeral-containers branch 3 times, most recently from 587901f to 84ebf3d Compare December 7, 2024 17:12
@GlassOfWhiskey GlassOfWhiskey force-pushed the master branch 2 times, most recently from 9660fdc to 90a078e Compare December 13, 2024 12:08
Copy link

codecov bot commented Feb 12, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
992 3 989 1
View the top 3 failed test(s) by shortest run time
common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/conformance_test_v1.0.cwltest.yaml::conformance_test_v1::0::cwltest::yaml::dockeroutputdir
Stack Traces | 0.104s run time
CWL test execution failed. 
Returned non-zero but it should be zero
Test: job: 
  file:.../streamflow/common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/v1.0/empty.json
output:
  thing:
    checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
    location: thing
    class: File
    size: 0
tool: 
  file:.../streamflow/common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/v1.0/docker-output-dir.cwl
label: dockeroutputdir
id: 103
doc: Test dockerOutputDirectory
tags:
- docker
- command_line_tool
line: '1410'
common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/conformance_test_v1.0.cwltest.yaml::conformance_test_v1::0::cwltest::yaml::initial_workdir_output
Stack Traces | 0.316s run time
CWL test execution failed. 
Returned non-zero but it should be zero
Test: job: 
  file:.../streamflow/common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/v1.0/initialworkdirrequirement-docker-out-job.json
output:
  OUTPUT:
    checksum: sha1$aeb3d11bdf536511649129f4077d5cda6a324118
    location: ref.fasta
    secondaryFiles:
    - checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
      location: ref.fasta.fai
      class: File
      size: 0
    class: File
    size: 12010
tool: 
  file:.../streamflow/common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/v1.0/initialworkdirrequirement-docker-out.cwl
label: initial_workdir_output
id: 98
doc: Test output of InitialWorkDir
tags:
- docker
- initial_work_dir
- command_line_tool
line: '1328'
common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/conformance_test_v1.0.cwltest.yaml::conformance_test_v1::0::cwltest::yaml::initial_workdir_secondary_files_expr
Stack Traces | 1.05s run time
CWL test execution failed. 
Returned non-zero but it should be zero
Test: job: 
  file:.../streamflow/common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/v1.0/search-job.json
output:
  outfile:
    class: File
    checksum: sha1$e2dc9daaef945ac15f01c238ed2f1660f60909a0
    location: result.txt
    size: 142
  indexedfile:
    location: input.txt
    class: File
    checksum: sha1$327fc7aedf4f6b69a42a7c8b808dc5a7aff61376
    secondaryFiles:
    - location: input.txt.idx1
      class: File
      checksum: sha1$1f6fe811644355974cdd06d9eb695d6e859f3b44
      size: 1500
    - location: input.idx2
      class: File
      checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
      size: 0
    - location: input.txt.idx3
      class: File
      checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
      size: 0
    - location: input.txt.idx4
      class: File
      checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
      size: 0
    - location: input.txt.idx5
      class: File
      checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
      size: 0
    - location: input.idx6.txt
      class: File
      checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
      size: 0
    - checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
      class: File
      location: input.txt.idx7
      size: 0
    - checksum: sha1$47a013e660d408619d894b20806b1d5086aab03b
      class: File
      location: hello.txt
      size: 13
    - class: Directory
      listing:
      - basename: index
        checksum: sha1$da39a3ee5e6b4b0d3255bfef95601890afd80709
        class: File
        location: index
        size: 0
      location: input.txt_idx8
    size: 1111
tool: 
  file:.../streamflow/common-workflow-language-1c1f122f780075d910fdfdea7e15e46eef3c078d/v1.0/v1.0/search.cwl#main
label: initial_workdir_secondary_files_expr
id: 55
doc: Test InitialWorkDirRequirement linking input files and capturing secondaryFiles
  on input and output. Also tests the use of a variety of parameter references and
  expressions in the secondaryFiles field.
tags:
- initial_work_dir
- inline_javascript
- command_line_tool
line: '551'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants