Skip to content

Conversation

nimalank7
Copy link
Contributor

Description:

Description:
- Previous chart version of v1.16.0 caused a [schema generation bug](kubernetes-sigs/external-dns#5209). See also #1878
- The schema generation bug is fixed in [v1.16.1](kubernetes-sigs/external-dns#5270)
- `provider` has to be turned into object as per the [schema validation](https://github.com/kubernetes-sigs/external-dns/blob/5eaf814b9420f88152a5f76aa0e48991eaead9ee/charts/external-dns/values.schema.json#L263)
@nimalank7 nimalank7 requested a review from a team April 24, 2025 18:32
@nimalank7
Copy link
Contributor Author

Closes #1879

Copy link
Contributor

@AgaDufrat AgaDufrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'd normally push the necessary fix to the Dependabot/Renovate PR, which saves clicking around to find more context and having to close the automated PR.

@nimalank7 nimalank7 merged commit 4152f0c into main Apr 28, 2025
8 checks passed
@nimalank7 nimalank7 deleted the BAU-upgrade-external-dns-v1.16.1 branch April 28, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants