Support Debian-specific install dir for ament_cmake_python #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Röhling <[email protected]>
|
We attempted to address this in #386 but it has continually fallen off our radar. I'll find some time to look at this PR this week. |
|
"this week" came and went, but I'm here now. Can we update this to take a similar approach to colcon? In particular, it would be preferable not to rely on private API in sysconfig: https://github.com/colcon/colcon-core/blob/master/colcon_core/python_install_path.py |
Signed-off-by: Timo Röhling <[email protected]>
|
Thanks!
|
mjeronimo
approved these changes
Mar 28, 2023
cottsay
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian recently added a new default scheme
posix_localfor Python installations, which hardcodes/usr/localand ignores thebasevariable, thereby breaking thePYTHON_INSTALL_DIRdiscovery inament_cmake_python.This PR will explicitly use the
deb_systemscheme if available (which matches the old behavior on Debian and Ubuntu) and fall back to the default scheme for other OS.