param '-P' dont work

[oblivcheck]

wf-recorder -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac --audio-codec-param b=384k

wf-recorder -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac -P b=384k

AAC audio bitrate always lock to 128k

it doesn't even output like:

Setting codec option: .........

#268
#135
#79

[soreau]

Does it work if you try -Pb=384k or --audio-codec-param='b=384k'?

[oblivcheck]

Does it work if you try -Pb=384k or --audio-codec-param='b=384k'?

not work

[soreau]

Hm, I see that load_audio_codec_options() is defined but never called anywhere it seems. Maybe you have found a bug.

[soreau]

Does this patch help?

[oblivcheck]

same, dont work

[soreau]

Can you elaborate about what you've tried that isn't working after applying the patch? Do you still not get the message stating the option set?

[soreau]

Here, if I run $ wf-recorder -o DP-3 -a -Pb=384k -f /tmp/wf-recorder.mp4, I at least see the output Setting codec option: b=384k.

[oblivcheck]

Do you still not get the message stating the option set?
yes

./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac --audio-codec-param b=384k
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac -P b=384k
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac -P b=192k
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac -P b=192
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac  -Pb=384k
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac  --audio-codec-param='b=384k'
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1   --audio-codec-param='b=384k'
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mp4 -F scale=1280:-1  -C aac  -Pb=384k
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mkv  -C aac  -Pb=384k
./wf-recorder  -a -c libx264 -r 25 -x yuv444p -f test.mkv  -C aac  -P b=384k

[soreau]

Can you show the complete output with -Pb=384k set? Maybe the patch isn't applied correctly or something.

[oblivcheck]

3 master(+1/-1)* ± ./wf-recorder -a -Pb=384k -f /tmp/wf-recorder.mp4
selected region 0,0 0x0
Setting codec option: crf=20
Setting codec option: preset=ultrafast
Setting codec option: tune=zerolatency
Using video filter: null
[libx264 @ 0x7fdd38003380] using SAR=1/1
[libx264 @ 0x7fdd38003380] MB rate (8160000000) > level limit (16711680)
[libx264 @ 0x7fdd38003380] using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2
[libx264 @ 0x7fdd38003380] profile Constrained Baseline, level 6.2, 4:2:0, 8-bit
[libx264 @ 0x7fdd38003380] 264 - core 157 - H.264/MPEG-4 AVC codec - Copyleft 2003-2018 - http://www.videolan.org/x264.html - options: cabac=0 ref=1 deblock=0:0:0 analyse=0:0 me=dia subme=0 psy=1 psy_rd=1.00:0.00 mixed_ref=0 me_range=16 chroma_me=1 trellis=0 8x8dct=0 cqm=0 deadzone=21,11 fast_pskip=1 chroma_qp_offset=0 threads=8 lookahead_threads=8 sliced_threads=1 slices=8 nr=0 decimate=1 interlaced=0 bluray_compat=0 constrained_intra=0 bframes=0 weightp=0 keyint=250 keyint_min=25 scenecut=0 intra_refresh=0 rc=crf mbtree=0 crf=20.0 qcomp=0.60 qpmin=0 qpmax=69 qpstep=4 ip_ratio=1.40 aq=0
Setting codec option: b=384k
Choosing sample format fltp for audio codec aac
Output #0, mp4, to '/tmp/wf-recorder.mp4':
  Stream #0:0: Video: h264 (libx264), yuv420p(pc), 1920x1080 [SAR 1:1 DAR 16:9], q=-1--1
  Stream #0:1: Audio: aac (LC), 48000 Hz, stereo, fltp, 128 kb/s
Using PulseAudio device: default

[soreau]

It's right there.. Setting codec option: b=384k..

[oblivcheck]

It's right there.. Setting codec option: b=384k..

sorry, I didn't see

[oblivcheck]

but

Stream #0:1: Audio: aac (LC), 48000 Hz, stereo, fltp, 128 kb/s

[soreau]

I think the only thing that can be done here is to decrease the audio bitrate, not increase it. This can be accomplished by setting the audio sample rate with -R. Here, the only way I was able to make a difference was with -R8000 which gave Stream #0:1: Audio: aac (LC), 8000 Hz, stereo, fltp, 96 kb/s instead of 128k.

[soreau]

Actually, with -Clibfdk_aac I can wf-recorder -o DP-3 -Clibfdk_aac -a -R96000 -Pb=256k -f /tmp/wf-recorder.mp4 and get Stream #0:1: Audio: aac, 96000 Hz, stereo, s16, 279 kb/s. So I think you have found a bug in general, but it will require experimentation to do whatever it is you're trying to do.