Add support for 16 bit deep formats #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As FFmpeg does not currently have alpha-less variants of RGBA64, BGRA64, or RGBAF16, we use the alpha variants instead. This is not a significant problem in practice, because a) source buffers often have the X channel filled with ones b) encoding video generally drops the alpha channel c) worst case, the user can strip alpha with filters. If alpha-less formats ever become available, wf-recorder can switch to them.
Owner
Does this mean it won't compile with some earlier versions? Or will it just fail at runtime? It seems at least to compile here on FFmpeg 5.1.2. |
Contributor
Author
When compiled with older FFmpeg, if the compositor provides a half-float format (like WL_SHM_FORMAT_XBGR16161616F), wf-recorder will fail at runtime, producing an "Unknown format: " error. The 16 bit integer formats have been available in FFmpeg since about 2011. |
Owner
|
Ok, then we can safely merge. Thanks! |
ammen99
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be enough to close #155 .
I'm making this PR very early, because I sometimes use wf-recorder to test that sway/wlroots with high bit depth work properly. It may be quite a while before the prerequisites to actually use the new formats from this PR will be available in released software.
This can be tested with FFmpeg 6.0 (released early 2023), and sway built from the mstoeckl/sway/extra-bit-depths branch, and wlroots using the Vulkan renderer (requires git master or >= 0.17.0, set
WLR_RENDERER=vulkan). Run a nested instance of sway, and invokeswaymsg output '*' render_bit_depth 16orswaymsg output '*' render_bit_depth 16fto set the output buffer bit depth. (A nested instance is recommended here, because to test this with sway with the DRM backend, you'd need a relatively recent GPU so that the system that lists the appropriate plane formats indrm_info.)