Skip to content

Conversation

@llyyr
Copy link
Contributor

@llyyr llyyr commented Nov 26, 2022

No description provided.

Copy link
Owner

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ammen99 ammen99 merged commit bb3ed36 into ammen99:master Jan 2, 2023
@WhyNotHugo
Copy link
Contributor

This breaks building from tarballs, since git metadata is absent. Maybe this should be skipped if .git does not exist?

@WhyNotHugo
Copy link
Contributor

I think that this can be used: https://stackoverflow.com/a/69343589/107510

I'll try and produce a patch.

WhyNotHugo added a commit to WhyNotHugo/wf-recorder that referenced this pull request Aug 23, 2023
Given that the commands are called with `check: true`, meson will
immediately exit with an error if these commands exit non-zero.

See: ammen99#193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants