Add default codec parameters for libvpx/libvpx-vp9. #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a minimal set of options to enable realtime encoding.
Conan-Kudo
suggested changes
Dec 21, 2022
| static const std::map<std::string, const CodecOptions&> default_codec_options = { | ||
| {"libx264", default_x264_options}, | ||
| {"libx265", default_x264_options}, | ||
| {"libvpx", default_libvpx_options}, |
Contributor
There was a problem hiding this comment.
Shouldn't there be also a line for libvpx-vp9?
Contributor
Author
There was a problem hiding this comment.
No, it's a substring search so libvpx also matches libvpx-vp9.
The original code did that to avoid listing codec variants like libx264rgb and I preserved the behavior.
Contributor
There was a problem hiding this comment.
Ah, makes sense. Thanks for explaining.
Conan-Kudo
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minimal set of options to enable realtime encoding.
I have no idea what rate control options should be used, so I'm omitting these. Feel free to suggest a good defaults.