Use codec format which best matches input #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the most closely matching codec pixel format when the input format is not available. For example, with input bgr0, this will automatically prefer yuv444p over yuv420p when the codec supports it, leading to more accurate recording of colored text and other features with pixel-scale color variation.
ammen99
approved these changes
Aug 9, 2023
Owner
ammen99
left a comment
ammen99
left a comment
There was a problem hiding this comment.
Didn't know about the existence of this function, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will, if the codec cannot directly handle the input format, make wf-recorder choose the best matching format according to the ranking provided by
av_find_best_pix_fmt_of_2, instead of falling back to yuv420p or the first listed codec format.Note that wf-recorder currently defaults to the libvpx (VP8) recorder, which only supports (yuv420p yuva420p). For testing, I'd recommend using either
--codec libx264or--codec libvpx-vp9, since both of those support a much wider range of input formats.