Dynamically increase number of used buffers #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nowrep
changed the title
Contributor
Author
|
The major source of encode thread lag behind capture thread is the encoder initialization that happens after capturing first frame. We could discard first captured frame and wait for encoder to initialize to reduce the number of used buffers even further. On my system with this change: |
Owner
|
At this point, seems to me we should separate buffer management into a separate data structure (preferably also a different file) to keep the code readable. |
ammen99
reviewed
Aug 10, 2023
Start with two buffers and keep increasing by one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start with 2 buffers and increase it when encoding starts to fall behind capture.