Fix silent audio when recoding webm + opus #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rate time base in PTS and packet rescaling
soreau
approved these changes
Mar 3, 2025
Collaborator
soreau
left a comment
soreau
left a comment
There was a problem hiding this comment.
This seems like a good solution according to everything I've read. It fixes the problem without the extra libopus warning messages and printing the audio pts values increment by larger values, 960 instead of 20 in the case of vpx+libopus and 1024 in the default mp4 case. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes #287
There is no
[libopus @ 0x7a681021cf40] Queue input is backward in timewarning when recording.I did not test extensively this fix regarding other codecs and audio formats.