Automatically transpose video based on output transform #315
Conversation
|
This doesn't fix #173. The coordinates do not pass the |
I think there are two issues at hand. One is outdated wayfire causing #173. Two is a new feature, that rotates and flips the video where applicable so that the resulting video orientation is always top=up. This PR fixes the latter, so you are probably right that this doesn't fix the original poster's problem in #173. |
|
I have updated the commit message and description so this will not close any issues if merged. |
|
A question I have considered: Should there be a way to disable this functionality so the recording is not automatically transposed? Or is it safe to say that everyone expects the video to always be transposed to the output orientation? |
|
My .2 cents as an end-user: I think this is the good default I would expect. If I wanted the other way, I would probably play the video rotated before screen-grabbing it. |
True, and if they want it another way, they can reprocess it. |
|
@tkna91 I didn't want to clutter the other thread so I am responding here. I was able to reproduce this with two sway outputs, the 'first'/right-most at 90 and the second/left-most output normal. When I try wf-recorder with slurp on the 90 output, I get the same error as you. I tested and this works with master, so I will look into it and try to find out why this PR breaks it. Thanks for testing! |
|
I found out that the reason is because this PR switched from xdg-output to wl_output for getting the output geometry, but wlroots doesn't properly advertise the x/y coordinates, it just sends 0,0 for all outputs. This means wf-recorder is confused when using multiple outputs because it thinks they are overlapping. The wlroots devs position is that 'clients should not care' about this information and that if you want it, you must use xdg-output. This means binding both interfaces, just to get the transform for the output via wl_output and the rest via xdg-output. I will update this PR to do this when I have the gumption. |
|
@soreau Rotation has normalized. However, the selection appears to be disabled. 20250719-000640.mp4 |
Indeed, I was able to reproduce with your detailed feedback, thanks again for testing. I was under the impression that the width and height needed to be swapped, but apparently this isn't the case. So I omitted that code and it should be working with latest bits. |
|
@soreau It looks fine to me. 20250719-010512.mp4 |
|
@tkna91 That's great, thanks for verifying and for the videos, much appreciated! 👍 |
|
Nice, thanks! |
5 participants
No description provided.