feat: add output listing capability #317
Conversation
|
I would say that this is out of scope for wf-recorder. There are other tools to get this information, such as i.e. |
|
I know I mainly did this for scripting, but I guess it's still useful for anyone using wf-recorder to be able to quickly see what outputs they can record without needing to know about other tools. It just keeps everything self-contained. |
|
If there is more than one output and do not pass |
|
I don't want you to feel like you're wasting time, I'd rather see you solve your issue. I don't know how wf-recorder-gui works but maybe it could (optionally) install the required tools to use the program, such as wf-recorder and wayland-utils. Perhaps this could be a packaging dependency detail. The other thing is that this project belongs to @ammen99, and has the final say on whether or not to include a feature such as this. So I am reopening this for @ammen99 comments. |
|
I am not totally opposed to adding this, however it would make sense to print the outputs in the same way that we do that for the interactive selection. And you'd also need to update the manpage and the I also get that you can get this information from another place but given that we already have code for printing a list of outputs, I don't see why we couldn't add a flag like this as well. |
|
I might have forgotten to add the update on the help command in my unstaged changes oopsi. |
src/main.cpp
Outdated
| -l, --log Generates a log on the current terminal. Debug purposes. | ||
| -L, --list-ouput List the available outputs. |
There was a problem hiding this comment.
| -L, --list-ouput List the available outputs. | |
| -L, --list-output List the available outputs. |
src/main.cpp
Outdated
| init_wayland_client(); | ||
| load_output_info(); | ||
|
|
||
| int i = 1; |
There was a problem hiding this comment.
I would put this into a function to really reuse it, otherwise lgtm.
Fixes: 664fc45 ("feat: add output listing capability (ammen99#317)")
3 participants
I have added the -L / --list-output flag to list available outputs for use with -o.
This allows users to programmatically get output names, useful for scripting and GUI tools like wf-recorder-gui.