🏗🚀 Refactor and significantly speed up gulp check-links#25235
🏗🚀 Refactor and significantly speed up gulp check-links#25235rsimha merged 3 commits intoampproject:masterfrom rsimha:2019-10-23-RefactorLinkChecker
gulp check-links#25235Conversation
|
Hey @estherkim, these files were changed:
|
alanorozco
left a comment
There was a problem hiding this comment.
Are we sure we'd like to ignore build-system overall?
|
@alanorozco Can you post the rest of your comments in one go by clicking the "Start a review" button? Posting several comments one by one generates notification spam and makes it hard to collapse / group review comments. And thanks for reviewing! |
rsimha
left a comment
There was a problem hiding this comment.
Comments addressed.
Not sure what this comment means. We do include |
|
Nice set of changes! Thanks Raghu. |
|
Thanks for the reviews, everyone. All comments addressed. Merging now, so that #25182 can be unblocked. |
This PR builds on #25226 and refactors / significantly speeds up
gulp check-linksHighlights:
getFilesToCheck()intobuild-system/common/utils.js--filesand--local_changesflags (--filesnow supports lists of globs)gulp check-linkson all files in the repo (there are multiple thousands of links, so we only run the link checker on files changed by a PR)ignorePatternsoption ofmarkdown-link-checkand deletesfilterAllowedLinks()(addresses 🏗 Ignore markdown templates in link checker by convention #25226 (comment))gitDiffAddedNameOnlyMaster()infilesIntroducedByPr(significant speed up).mdfile as soon as they are available (better UX, also faster)BBPromisein favor of the native interface ofmarkdown-link-checkUsage:
Example:
Follow up to #25226