Skip to content

Commit 401df3d

Browse files
authored
Merge pull request #54 from SimonMarquis/patch-7
Replace unnecessary init block with direct instantiation in HomeViewModel.kt
2 parents 5407ff0 + de6a45e commit 401df3d

File tree

1 file changed

+8
-13
lines changed
  • feature/home/src/main/java/com/android/developers/androidify/home

1 file changed

+8
-13
lines changed

feature/home/src/main/java/com/android/developers/androidify/home/HomeViewModel.kt

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,27 +16,22 @@
1616
package com.android.developers.androidify.home
1717

1818
import androidx.lifecycle.ViewModel
19-
import androidx.lifecycle.viewModelScope
2019
import com.android.developers.androidify.data.ConfigProvider
2120
import dagger.hilt.android.lifecycle.HiltViewModel
2221
import kotlinx.coroutines.flow.MutableStateFlow
2322
import kotlinx.coroutines.flow.asStateFlow
24-
import kotlinx.coroutines.launch
2523
import javax.inject.Inject
2624

2725
@HiltViewModel
28-
class HomeViewModel @Inject constructor(val configProvider: ConfigProvider) : ViewModel() {
29-
private val _state = MutableStateFlow(HomeState())
26+
class HomeViewModel @Inject constructor(configProvider: ConfigProvider) : ViewModel() {
27+
private val _state = MutableStateFlow(
28+
HomeState(
29+
isAppActive = !configProvider.isAppInactive(),
30+
dancingDroidLink = configProvider.getDancingDroidLink(),
31+
videoLink = configProvider.getPromoVideoLink(),
32+
),
33+
)
3034
val state = _state.asStateFlow()
31-
init {
32-
viewModelScope.launch {
33-
_state.value = _state.value.copy(
34-
isAppActive = !configProvider.isAppInactive(),
35-
dancingDroidLink = configProvider.getDancingDroidLink(),
36-
videoLink = configProvider.getPromoVideoLink(),
37-
)
38-
}
39-
}
4035
}
4136

4237
data class HomeState(

0 commit comments

Comments
 (0)