Skip to content

Add OSS dialog to app #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2025
Merged

Add OSS dialog to app #68

merged 7 commits into from
Jun 24, 2025

Conversation

riggaroo
Copy link
Collaborator

@riggaroo riggaroo commented Jun 24, 2025

Screenshot_20250624_111901
Screenshot_20250624_111921

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the functionality to display open-source software licenses within the application. It involves adding the Google Play Services OSS Licenses library, configuring the Android manifest and Gradle build scripts, and integrating a new UI element on the 'About' screen to launch the licenses dialog.

Highlights

  • Open Source Licenses Integration: Integrated the Google Play Services OSS Licenses library to display open-source attributions within the application.
  • UI Addition: Added a new 'Licenses' button to the 'About' screen, providing a direct entry point for users to view the open-source licenses.
  • Build Configuration: Updated Gradle build files (app/build.gradle.kts, build.gradle.kts, feature/home/build.gradle.kts, gradle/libs.versions.toml) to include the necessary OSS licenses plugin and library dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds an Open Source Software licenses screen to the application. The implementation correctly uses the Google Play Services OSS Licenses library, including adding the necessary dependencies, Gradle plugin, and Android Manifest entries. The UI is also updated to provide a button to access this new screen.

I've left a couple of comments for minor cleanups:

  • A critical issue regarding an import of an internal Gradle API in the root build.gradle.kts file which should be removed.
  • A medium severity issue for an unused import in AboutScreen.kt.

Once these are addressed, the PR should be good to merge. Great work!

@riggaroo riggaroo marked this pull request as ready for review June 24, 2025 10:33
@riggaroo riggaroo merged commit 9ccdf88 into main Jun 24, 2025
3 checks passed
@riggaroo riggaroo deleted the feature/oss branch June 24, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants