Skip to content

[PlayerView] Shared element transitions not work on 1.4.0 #1594

Closed
@onlymash

Description

@onlymash

Version

Media3 1.4.0

More version details

After updating media3 to version 1.4.0, Shared element transitions fail. Specifically, PlayerView does not scale properly on Android 14 and above. The issue does not occur on Android 13. Reverting back to version 1.3.1 resolves the problem.

Devices that reproduce the issue

  • OnePlus 12 running Android 15 beta
  • Lenovo Legion Tab running Android 14

Devices that do not reproduce the issue

  • Lenovo Legion Tab running Android 13

Reproducible in the demo app?

Not tested

Reproduction steps

none

Expected result

none

Actual result

none

Media

example
1.3.1.webm
1.4.0.webm

Bug Report

  • You will email the zip file produced by adb bugreport to android-media-github@google.com after filing this issue.

Activity

onlymash

onlymash commented on Aug 5, 2024

@onlymash
Author

This may be caused by this commit
30cb762

icbaker

icbaker commented on Aug 5, 2024

@icbaker
Collaborator

This may be caused by this commit
30cb762

That commit shouldn't affect Android 15 (SDK_INT == 35), because all the logic is gated by a SDK_INT == 34 check, but you said that Android 15 did reproduce the issue. Please can you check that repro case again, and confirm the value of Build.VERSION.SDK_INT that you see?

If you are able to build locally and revert that change on top of 1.4.0 to confirm it as the culprit, that would also be very helpful.

self-assigned this
on Aug 5, 2024
onlymash

onlymash commented on Aug 5, 2024

@onlymash
Author

This may be caused by this commit
30cb762

That commit shouldn't affect Android 15 (SDK_INT == 35), because all the logic is gated by a SDK_INT == 34 check, but you said that Android 15 did reproduce the issue. Please can you check that repro case again, and confirm the value of Build.VERSION.SDK_INT that you see?

If you are able to build locally and revert that change on top of 1.4.0 to confirm it as the culprit, that would also be very helpful.

OnePlus 12's A15 beta is an early version, and the SDK_INT is still 34

onlymash

onlymash commented on Aug 5, 2024

@onlymash
Author

This may be caused by this commit
30cb762

That commit shouldn't affect Android 15 (SDK_INT == 35), because all the logic is gated by a SDK_INT == 34 check, but you said that Android 15 did reproduce the issue. Please can you check that repro case again, and confirm the value of Build.VERSION.SDK_INT that you see?

If you are able to build locally and revert that change on top of 1.4.0 to confirm it as the culprit, that would also be very helpful.

I reverted this commit and build it locally, and I can confirm that this commit caused it.

icbaker

icbaker commented on Aug 5, 2024

@icbaker
Collaborator

Thank for you for confirming.

Are you able to explain your repro set-up in more detail? You mention 'shared element transitions' - is that referring to this Compose feature? https://developer.android.com/develop/ui/compose/animation/shared-elements

If you have a code snippet describing how your UI is wired together, or even a minimal reproducible example that demonstrates the problem in a way that we can build locally, that would be really helpful.

The easiest way to do this is probably to fork this project and make changes in one of the demo apps, then link us to the fork.

Alternatively it could be an Android Studio project zipped up and sent to android-media-github@google.com with the subject "Issue #1594". If emailing please also update this issue to indicate you’ve done this.

15 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @nikclayton@icbaker@onlymash@google-oss-bot

      Issue actions

        [PlayerView] Shared element transitions not work on 1.4.0 · Issue #1594 · androidx/media