This commit will cause H265 ts to fail

[FongMi]

Version

Media3 main branch

More version details

029b8ba
If I revert the modification of H265Reader, it won't get stuck.

Before revert
problem.zip

After revert
no problem.zip

Devices that reproduce the issue

Devices that do not reproduce the issue

None

Reproducible in the demo app?

Not tested

Reproduction steps

I don't have the actual video URL
I asked users to test
Tested from media3 1.3.1 ~ 1.4.1
The problem was found to occur from 1.4.0-alpha02
And I compare 1.4.0-alpha01 and 1.4.0-alpha02
I just found a commit about H265
029b8ba

Expected result

Don't get stuck

no problem.zip

Actual result

get stuck

problem.zip

Media

Sample 1
https://drive.google.com/file/d/1k5sfTgYWf2r1fdnFlknkfoZ0Gr9PL0i5/view?usp=sharing

Sample 2
http://otttv.bj.chinamobile.com/PLTV/88888888/224/3221226893/1.m3u8?GuardEncType=2&accountinfo=%7E%7EV2.0%7EcnoJZd_sZxCC6bZYZh4R6g%7EtP4-l0lmSfjwLWEfK_el1vH_mv-s1zo4AQJwdedaVwG9xkuFTDg8J26cwOrNJzn20BErrHdLhuZ9EzLUCD3PMW-OMx4MGteHV2vLeW6BqoY%2CEND

Bug Report

• You will email the zip file produced by adb bugreport to android-media-github@google.com after filing this issue.

[FongMi]

@dsparano Do you have any ideas?

[Tangsan99999]

note

[dsparano]

I see, well I really need a H265 content that causes playback to hang in order to reproduce and find the issue, @FongMi can you please share one?

[FongMi]

@dsparano I have upload sample file and url.
But maybe some device won't happened, only special device will happened.

[tonihei]

@FongMi - can you easily build Media3 from source? If so, can you check if removing this line fixes the issue on your device?

@dsparano : This might be related to the discussion in #1189 (comment), either because one of the samples is too small or because the device can't handle the duplicate timestamp.

[FongMi]

@tonihei sure, I will try it tomorrow.

[FongMi]

@tonihei After remove the line, user says no problem.

[tonihei]

Thanks for confirming!

@rohitjoins would you mind having a look in case you have any ideas? It looks like issuing a single sample helps to avoid problems, but #1189 (comment) mentioned other HLS streams that have issues with the combined sample.

@dsparano: If you can think of another approach, please feel free to chime in as well :)

[dsparano]

@tonihei Thanks for your finding, at first glance removing that line seems to be working, however I'm double checking with the streams that got me into adding it, to reproduce the issue I was mentioning here, it shouldn't take too long

[dsparano]

Looking at the stream originally from this comment: by removing the first outputSample line it only plays 1490 frames out of 1500 in this stream. Basically all the last samples of each of the 10 segments will not be passed. It looks to me we need a slightly tweaked approach, let me try and find it.

[dsparano]

@FongMi tbh I couldn't reproduce any issue with Sample 1 or Sample 2 on a few devices I've here, besides now Sample 2 doesn't seem to be working anymore, if you could pls check