Skip to content

Multi period content support for AdsMediaSource #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kotucz
Copy link

@kotucz kotucz commented Jun 4, 2025

Multi period DASH content ads support inspired by #1642 (comment)
At Timeline level, the original AdPlaybackState is divided and adjusted for each of the periods.

Removing single period assertions from AdsMediaSource.
Providing MultiPeriodAdTimeline as an alternative to current SinglePeriodAdTimeline.
From input AdPlaybackState, new modified AdPlaybackState is created - one for each period:

  • ad group time is offset relative to period start time
  • ad groups after period end time are marked as skipped
  • post-roll ad group is kept only for last period
  • ad group count and indices are kept constant

Copy link

google-cla bot commented Jun 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@icbaker
Copy link
Collaborator

icbaker commented Jun 4, 2025

Please sign the CLA, then we can take a look at this PR

@kotucz
Copy link
Author

kotucz commented Jun 10, 2025

Company CLA should be used. It is in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants