Skip to content

Avoid overriding function in Base since v1.2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nickrobinson251
Copy link
Contributor

  • This adds a version check to function we define that were since added to Base.
  • Enables CI for 1.1 and 1.2 (these functions were added to Base in 1.2)
  • ...and wraps the tests in a testset (this can be reverted / a separate PR if you prefer -- i just noticed it when running tests)

Warnings fixed by this change (in v"1.2.0-rc2.0"):

julia> using AcceleratedArrays
[ Info: Recompiling stale cache file /Users/nick/.julia/compiled/v1.2/AcceleratedArrays/mcm9V.ji for AcceleratedArrays [44e12807-9a19-5591-91cf-c1b4fb89ce64]
WARNING: Method definition <(Any) in module Base at operators.jl:1015 overwritten in module AcceleratedArrays at /Users/nick/.julia/packages/AcceleratedArrays/vPA4c/src/predicates.jl:53.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition <=(Any) in module Base at operators.jl:989 overwritten in module AcceleratedArrays at /Users/nick/.julia/packages/AcceleratedArrays/vPA4c/src/predicates.jl:54.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition >(Any) in module Base at operators.jl:1002 overwritten in module AcceleratedArrays at /Users/nick/.julia/packages/AcceleratedArrays/vPA4c/src/predicates.jl:55.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition >=(Any) in module Base at operators.jl:976 overwritten in module AcceleratedArrays at /Users/nick/.julia/packages/AcceleratedArrays/vPA4c/src/predicates.jl:56.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition !=(Any) in module Base at operators.jl:963 overwritten in module AcceleratedArrays at /Users/nick/.julia/packages/AcceleratedArrays/vPA4c/src/predicates.jl:57.
  ** incremental compilation may be fatally broken for this module **

@nickrobinson251 nickrobinson251 changed the title Npr/version check operators Avoid overriding function in Base since v1.2 Jul 26, 2019
@iamed2
Copy link

iamed2 commented Jul 26, 2019

Useful for https://github.com/invenia/IndexedDims.jl :)

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #3 into master will increase coverage by 0.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage    72.7%   73.13%   +0.42%     
==========================================
  Files          11       12       +1     
  Lines         403      402       -1     
==========================================
+ Hits          293      294       +1     
+ Misses        110      108       -2
Impacted Files Coverage Δ
src/predicates.jl 82.75% <0%> (ø) ⬆️
src/AcceleratedArray.jl 50% <0%> (-7.15%) ⬇️
src/AcceleratedArrays.jl 100% <0%> (ø)
src/SortIndex.jl 96.96% <0%> (+4.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7381041...45919ea. Read the comment docs.

@nickrobinson251
Copy link
Contributor Author

ping @andyferris :)

Copy link
Owner

@andyferris andyferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - nice work. thanks @nickrobinson251! (Sorry for the delay)

@andyferris andyferris merged commit 91c4061 into andyferris:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants