Language service not loading with config option "files: []"

[lincolnthree]

Describe the bug

Angular HTML Template syntax validation/completion/intelli-sense are not working.

To Reproduce

Steps to reproduce the behavior:

1. npm install -g @angular/cli@next
2. ng new angular10example
3. cd angular10example
4. npm i
5. Open project in VSCode with Angular Language Service extension installed

Expected behavior

Angular HTML template editor should provide validition, syntax checking, completion and "go to definition" functionality. Etc etc.

Logs

Please attach two logs:

1. Console output (Go to toolbar --> View --> Output, and copy the contents)

[Info  - 4:28:28 PM] Angular language server process ID: 34506
[Info  - 4:28:28 PM] Using typescript v3.8.3 from /Users/lincoln/.vscode/extensions/angular.ng-template-0.901.9/node_modules/typescript/lib/tsserverlibrary.js
[Info  - 4:28:28 PM] Using @angular/language-service v9.1.9 from /Users/lincoln/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js
[Info  - 4:28:28 PM] Log file: /Users/lincoln/Library/Application Support/Code/logs/20200526T132525/exthost4/Angular.ng-template/nglangsvc.log
[Info  - 4:28:30 PM] Disabling language service for /Users/lincoln/projects/maritlabs/libraries/angular10example/tsconfig.json because it is not an Angular project ('@angular/core/core.d.ts' could not be found). If you believe you are seeing this message in error, please reinstall the packages in your package.json.
[Error - 4:28:30 PM] No config file for /Users/lincoln/projects/maritlabs/libraries/angular10example/src/app/app.component.html

2. Log file (Path is printed to the console output at startup)

nglangsvc.log

Screenshots

Additional context

Not sure when this stopped working. It actually hasn't been working for me for about a week, even in my Angular 9 project, and I haven't been able to figure out what's causing the problem, but I've since upgraded to Angular 10 and it's still not working.

[lincolnthree]

I have also tried using TypeScript 3.9.3 from the project TS version.

[lincolnthree]

I have tried setting angular.nsdk to use the @angular/language-service version 10.0.0-rc1 from the project's node_modules.

[lincolnthree]

From another workspace:

[Info  - 4:35:45 PM] Angular language server process ID: 34938
[Info  - 4:35:45 PM] Using typescript v3.9.3 from /Users/lincoln/projects/maritlabs/topdecked-unified/node_modules/typescript/lib/tsserverlibrary.js
[Info  - 4:35:45 PM] Using @angular/language-service v10.0.0-rc.0 from /Users/lincoln/projects/maritlabs/topdecked-unified/node_modules/@angular/language-service/bundles/language-service.umd.js
[Info  - 4:35:45 PM] Log file: /Users/lincoln/Library/Application Support/Code/logs/20200526T132525/exthost1/Angular.ng-template/nglangsvc.log
[Info  - 4:35:51 PM] Disabling language service for /Users/lincoln/projects/maritlabs/topdecked-unified/tsconfig.json because it is not an Angular project ('@angular/core/core.d.ts' could not be found). If you believe you are seeing this message in error, please reinstall the packages in your package.json.
[Info  - 4:35:51 PM] Enabling language service for /Users/lincoln/projects/maritlabs/topdecked-unified/tsconfig.app.json.
[Info  - 4:35:51 PM] Enabling language service for /Users/lincoln/projects/maritlabs/topdecked-unified/tsconfig.worker.json.
[Info  - 4:35:51 PM] Disabling language service for /Users/lincoln/projects/maritlabs/topdecked-unified/e2e/tsconfig.e2e.json because it is not an Angular project ('@angular/core/core.d.ts' could not be found). If you believe you are seeing this message in error, please reinstall the packages in your package.json.
[Error - 4:35:51 PM] No config file for /Users/lincoln/projects/maritlabs/topdecked-unified/src/app/pages/home/home.page.htm

And the log file:
exthost.log

[ayazhafiz]

Thanks for the report!

I could not reproduce this with the steps you provided. Could you verify that you've opened VSCode to the root of the project, and the root contains node_modules/@angular/core/core.d.ts?

[lincolnthree]

@ayazhafiz You're welcome! Thanks for taking a look.

Hoping I can figure out what's going on here. Been burning a lot of time without these features :/

sharktop:topdecked-unified lincoln$ ls node_modules/@angular/core/core.d.ts
-rw-r--r--  1 lincoln  staff  1258907 May 26 16:20 node_modules/@angular/core/core.d.ts
sharktop:topdecked-unified lincoln$

Same behavior. When run from project directory:

Ran VSCode:

sharktop:topdecked-unified lincoln$ code .

Opened app.component.html, VSCode NGLS Log:

[Info  - 9:04:01 AM] Angular language server process ID: 37826
[Info  - 9:04:01 AM] Using typescript v3.8.3 from /Users/lincoln/.vscode/extensions/angular.ng-template-0.901.9/node_modules/typescript/lib/tsserverlibrary.js
[Info  - 9:04:01 AM] Using @angular/language-service v10.0.0-rc.0 from /Users/lincoln/projects/maritlabs/topdecked-unified/node_modules/@angular/language-service/bundles/language-service.umd.js
[Info  - 9:04:01 AM] Log file: /Users/lincoln/Library/Application Support/Code/logs/20200527T090334/exthost1/Angular.ng-template/nglangsvc.log
[Info  - 9:04:03 AM] Disabling language service for /Users/lincoln/projects/maritlabs/topdecked-unified/tsconfig.json because it is not an Angular project ('@angular/core/core.d.ts' could not be found). If you believe you are seeing this message in error, please reinstall the packages in your package.json.
[Error - 9:04:03 AM] No config file for /Users/lincoln/projects/maritlabs/topdecked-unified/src/app/app.component.html

Completion / etc still not working :/

[lincolnthree]

These are my other installed extensions, for reference:

[lincolnthree]

I also should have reported that this is occurring on MacOS.

[lincolnthree]

What other info should I be looking at / what can I provide to get to the bottom of this?

[lincolnthree]

My uneducated overview of the log file leads me to believe that there is an issue with the new reference-based tsconfig.json structure in Angular 10 projects causing the language service to fail to resolve typescript and other various other file roots and settings. But that doesn't hold up since you said it worked for you.

Also doesn't explain why it was already failing before the upgrade to Angular 9. Something feels fishy.

Log from the last attempt:

nglangsvc.log

[lincolnthree]

I've been 'hacking' tsconfig.json a bit to try to get the angular language service to recognize it as an angular project... finally ended up with something a little different:

{
  "extends": "../tsconfig.base.json",
  "files": [],
  "references": [{
      "path": "./tsconfig.app.json"
    },
    {
      "path": "./tsconfig.spec.json"
    },
    {
      "path": "./tsconfig.worker.json"
    }
  ],
  "include": [
    "node_modules"
  ],
  "angularCompilerOptions": {
    "enableIvy": true,
    "fullTemplateTypeCheck": false,
    "skipTemplateCodegen": false,
    "skipTemplates": true,
    "strictInjectionParameters": true,
    "strictMetadataEmit": false
  }
}

[Info  - 9:43:15 AM] Angular language server process ID: 39364
[Info  - 9:43:15 AM] Using typescript v3.9.3 from /Users/lincoln/projects/maritlabs/topdecked-unified/node_modules/typescript/lib/tsserverlibrary.js
[Info  - 9:43:15 AM] Using @angular/language-service v9.1.9 from /Users/lincoln/.vscode/extensions/angular.ng-template-0.901.9/server/node_modules/@angular/language-service/bundles/language-service.umd.js
[Info  - 9:43:15 AM] Log file: /Users/lincoln/Library/Application Support/Code/logs/20200527T093711/exthost1/Angular.ng-template/nglangsvc.log
[Info  - 9:43:32 AM] Enabling language service for /Users/lincoln/projects/maritlabs/topdecked-unified/tsconfig.json.
[Error - 9:43:32 AM] No config file for /Users/lincoln/projects/maritlabs/topdecked-unified/src/app/pages/home/home.page.html
Warning: Can't resolve all parameters for Router in /Users/lincoln/projects/maritlabs/topdecked-unified/node_modules/@angular/router/router.d.ts: ([object Object], [object Object], [object Object], [object Object], [object Object], [object Object], [object Object], ?). This will become an error in Angular v6.x
Warning: Can't resolve all parameters for ɵangular_packages_router_router_o in /Users/lincoln/projects/maritlabs/topdecked-unified/node_modules/@angular/router/router.d.ts: ([object Object], [object Object], ?). This will become an error in Angular v6.x

nglangsvc.log

[ayazhafiz]

What did your tsconfig look like originally?

[ayazhafiz]

The one listed in the log file is the output after the config file is parsed by TS, so it doesn't always line up (e.g. in regard to rootNames)

[ayazhafiz]

The issue is that files: [] tells TypeScript's tsserver to load a project with no files (other than the config file). This project is passed to the Angular language service. The project is also all the language service has to work with, so if core.d.ts or any TypeScript files can't be found in the project files (as in this case), the language service is disabled.