Utilize create_matcherror more in other rules #4408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
af57bd0 to
54f255a
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
54f255a to
fe6e7eb
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
b7368ff to
53bdc4b
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
53bdc4b to
6cb0612
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
6cb0612 to
4a913fe
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
4a913fe to
13dc9da
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
13dc9da to
d486b25
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
d486b25 to
942412b
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
942412b to
93196a2
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
93196a2 to
ac61574
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
ec98714 to
b9e8806
Compare
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
b9e8806 to
9547ace
Compare
The imports of the MatchError class have been moved under the TYPE_CHECKING conditional because the rules changed now only rely solely on the class for typing, and no longer require it at runtime.
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
9547ace to
f03ffbd
Compare
ssbarnea
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the
var-namingrule the other day, I wondered why this rule didn't use thecreate_matcherrormethod like other rules. Hence, to keep consistent with other rules, I added the method to rules still explicitly creatingMatchErrorinstances.