Refactor line number identification #4564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhikdps
approved these changes
Mar 25, 2025
alisonlhart
approved these changes
Mar 25, 2025
- require ansible>=2.16.11 instead of 2.16.0 due to change in behavior regarding some exceptions. - add support for ansible-core 2.19 with data tagging Related: AAP-41586
ssbarnea
added a commit
that referenced
this pull request
Apr 1, 2025
Fixes a problem with incomplete error messages from ansible-core Part-Of: #4564
ssbarnea
added a commit
that referenced
this pull request
Apr 1, 2025
Fixes a problem with incomplete error messages from ansible-core Part-Of: #4564
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
cavcrosby
pushed a commit
to cavcrosby/homelab-cm
that referenced
this pull request
Oct 11, 2025
The ruff pre-commit hook has been updated to the ruff-check hook, as the former is now just an alias for the latter. The GitHub pull request, astral-sh/ruff-pre-commit#124, discusses these changes. The spacing underneath many lines within the code.md and infrastructure.md Markdown files has changed due to Prettier's pre-commit hook formatting them. Also, many link texts have changed to satisfy markdownlint's new MD059 rule (link text should be descriptive). The use_keywords_order_plays.yml playbook has changed to resolve ansible-lint name[unique] violations. Many role variables have been changed to resolve ansible-lint var-naming[no-role-prefix] violations. Passing the line number for tasks and plays (via 'data') as an argument to the create_matcherror method has changed due to how this attribute is to be accessed in relation to future versions of the ansible-core package (>= 2.19). This conclusion has come from reading ansible/ansible-lint#4554 and ansible/ansible-lint#4564. A version_changed attribute has been added to all rules to suppress a warning now generated from ansible-lint that complains when this attribute is missing. This behavior was introduced as of this commit: ansible/ansible-lint#4431. The value for this attribute models the one in the pyproject.toml file, in that it is not intended to hold much significance. This is primarily because I see little value in updating this attribute over time for internal rules. The _get_leaf_items method's type hint has changed from the union type 'list[Any] | dict[Any, Any]' to 'list[Any] | Mapping[Any, Any]' because the parent class type of ansiblelint.utils.Task has changed to be Mapping[str, Any]. The AnsibleUnicodeItems type alias now uses the 'type' keyword instead of TypeAlias, as this was recommended per ruff's non-pep695-type-alias rule.
cavcrosby
pushed a commit
to cavcrosby/homelab-cm
that referenced
this pull request
Oct 18, 2025
The ruff pre-commit hook has been updated to the ruff-check hook, as the former is now just an alias for the latter. The GitHub pull request, astral-sh/ruff-pre-commit#124, discusses these changes. The spacing underneath many lines within the code.md and infrastructure.md Markdown files has changed due to Prettier's pre-commit hook formatting them. Also, many link texts have changed to satisfy markdownlint's new MD059 rule (link text should be descriptive). The use_keywords_order_plays.yml playbook has changed to resolve ansible-lint name[unique] violations. Many role variables have been changed to resolve ansible-lint var-naming[no-role-prefix] violations. Passing the line number for tasks and plays (via 'data') as an argument to the create_matcherror method has changed due to how this attribute is to be accessed in relation to future versions of the ansible-core package (>= 2.19). This conclusion has come from reading ansible/ansible-lint#4554 and ansible/ansible-lint#4564. A version_changed attribute has been added to all rules to suppress a warning now generated from ansible-lint that complains when this attribute is missing. This behavior was introduced as of this commit: ansible/ansible-lint#4431. The value for this attribute models the one in the pyproject.toml file, in that it is not intended to hold much significance. This is primarily because I see little value in updating this attribute over time for internal rules. The _get_leaf_items method's type hint has changed from the union type 'list[Any] | dict[Any, Any]' to 'list[Any] | Mapping[Any, Any]' because the parent class type of ansiblelint.utils.Task has changed to be Mapping[str, Any]. The AnsibleUnicodeItems type alias now uses the 'type' keyword instead of TypeAlias, as this was recommended per ruff's non-pep695-type-alias rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: AAP-41586