fix: correct partial-become rule documentation comments #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <[email protected]>
ssbarnea
approved these changes
Jan 5, 2026
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR fixes documentation issues in
partial_become.md. The main fix addresses issue #4825 where a comment in the "Correct Code" section incorrectly stated the user wouldn't change. Additionally, it corrects a grammar error and updates misleading comments in the "Problematic Code" sections that incorrectly claimed the user wouldn't change - when the actual issue is thatbecomeandbecome_usershould be defined at the same level for maintainability, not that Ansible wouldn't work.Closes #4825.