fix: allow valid tabs in lineinfile nested in blocks (#4719) #4881
+36
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jkhall81
force-pushed
the
fix/4719-no-tabs-block-nesting
branch
from
bbd6c5f to
b415e9a
Compare
Jkhall81
force-pushed
the
fix/4719-no-tabs-block-nesting
branch
from
b415e9a to
69a154b
Compare
Jkhall81
changed the title
Jkhall81
force-pushed
the
fix/4719-no-tabs-block-nesting
branch
from
69a154b to
736a7f9
Compare
Jkhall81
changed the title
Jkhall81
force-pushed
the
fix/4719-no-tabs-block-nesting
branch
from
736a7f9 to
c7b832c
Compare
Jkhall81
force-pushed
the
fix/4719-no-tabs-block-nesting
branch
from
c7b832c to
4c42db3
Compare
Jkhall81
force-pushed
the
fix/4719-no-tabs-block-nesting
branch
from
4c42db3 to
2ad6390
Compare
Jkhall81
force-pushed
the
fix/4719-no-tabs-block-nesting
branch
from
2ad6390 to
7d4e3e0
Compare
ssbarnea
approved these changes
Jan 5, 2026
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a context-blindness issue where the
no-tabsrule incorrectly flagged valid tab characters inlineinfiletasks when they were nested inside ablock. By refactoringmatchtaskto validate keys gainst theallow_listglobally within the task structure, the rule now correctly identifies whitelisted parameters (likeregexporline) regardless of nesting depth.Fixes #4719