fix: ensure exclude_paths are honored for unparseable files #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
approved these changes
Jan 6, 2026
Contributor
Author
|
@ssbarnea I was going to mention the pathspec thing, but I checked the actions tab and it looks like you are already on it. Nice. |
Fixes exclusion logic to correctly skip files that fail YAML loading. This prevents crashes on SOPS or invalid YAML when they are explicitly excluded. Fixes ansible#4745
auto-merge was automatically disabled
January 6, 2026 12:25
Head branch was pushed to by a user without write access
Jkhall81
force-pushed
the
fix/issue-4745-exclude-yaml
branch
from
e9a905a to
2023d0b
Compare
github-project-automation
bot
moved this from Review
to Done
in 🧰 devtools project board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that
exclude_pathsare correctly honored for unparseable or encrypted files (e.g., SOPS).Previously, files that failed to load as valid YAML would trigger a
load-failureeven if they were explicitly excluded in the configuration. This occurred because explicit targets would bypass exclusion checks during the initialization phase.Changes
Runner._run()to perform a direct exclusion check when a YAML load exception is encountered.load-failureerrors for any file matching the exclusion patterns, allowing the linter to skip them gracefully instead of crashing.Fixes #4745