chore: refactor testing code to reduce use of get_app() #4890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/app-cache
branch
from
af12c09 to
4d031b4
Compare
- allow use of uv if a venv is already active - remove grammarly from suggestions - refactor formatter tests to avoid running code like get_app when the module is imported - use pytest fixture to obtain rules collection used for testing, so we can remove another use of get_app() Related: AAP-60425
ssbarnea
force-pushed
the
fix/app-cache
branch
from
cd695c9 to
9858735
Compare
ssbarnea
changed the title
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: AAP-60425