feat: allow logos Linux 26 1 #2048
Conversation
github-actions
bot
added
testing
…s/pyansys-geometry into feat/allow_logos_linux_26_1
tests/test_connection.py
Outdated
| @pytest.mark.skipif( | ||
| sys.platform.startswith("linux"), | ||
| reason="Test skipped on Linux because it is specific to Windows backends.", | ||
| ) |
There was a problem hiding this comment.
We should use the is_linux_service() call here rather than using "sys". You could be testing against a remote Linux service from a Windows environment.. and then the test would get executed :)
There was a problem hiding this comment.
@RobPasMue I can make that change
There was a problem hiding this comment.
Oh... now that I think of it. You might actually have to go with "sys". You are attempting to launch the backend so you can't perform that call... really sorry!
There was a problem hiding this comment.
Or you might bot even need to skip it, right? Because the execution will never happen so you are safe in any case
There was a problem hiding this comment.
I think it failed before I skipped it for Linux
There was a problem hiding this comment.
Just checked, makes sense. Those errors are only happening if running on a Windows system. I would skip the test if anybody tries to run it on anything else than Windows... so:
pytest.mark.skipif(
os.name != "nt",
reason="Test skipped on Linux because it is specific to Windows backends.",
)There was a problem hiding this comment.
Sorry for all the fuss @RyanJWard ... I didn't read the test properly the first time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
+ Coverage 92.30% 92.53% +0.23%
==========================================
Files 136 136
Lines 9811 9811
==========================================
+ Hits 9056 9079 +23
+ Misses 755 732 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
With the latest 26.1 Linux service prepare logo tools should be fixed
Checklist
feat: extrude circle to cylinder)