Add __repr__ for DagTag so it displays properly in /dagmodel/show#8719
Merged
XD-DENG merged 2 commits intoapache:masterfrom May 5, 2020
Merged
Add __repr__ for DagTag so it displays properly in /dagmodel/show#8719XD-DENG merged 2 commits intoapache:masterfrom
XD-DENG merged 2 commits intoapache:masterfrom
Conversation
kaxil
reviewed
May 5, 2020
Member
kaxil
left a comment
There was a problem hiding this comment.
can we add a simple test for this?
Member
Author
Thanks @kaxil . I was thinking of this as well, but didn't do it given it's too simple change. Let me re-think how I should do it. Will update here. |
Member
I mean just assert that "repr(ExampleDagTag) == 'ExampleDagTag'" |
Member
Author
|
Hi @kaxil , unit test is updated. May be a bit "more" than you expected, but I think it's worthwhile |
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…pache#8719) (cherry picked from commit c717d12)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Dag Tags are not displayed properly in UI page
/dagmodel/show/<dag_id>This issue exists in both
masterand1.10.10How to Reproduce
Before Fix
After fix
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.