Add extra options for slack webhook operator and slack hook#9409
Merged
dimberman merged 1 commit intoapache:v1-10-testfrom Jun 23, 2020
benbenbang:enh/add_extra_option_slackwhoptr
Merged
Add extra options for slack webhook operator and slack hook#9409dimberman merged 1 commit intoapache:v1-10-testfrom benbenbang:enh/add_extra_option_slackwhoptr
dimberman merged 1 commit intoapache:v1-10-testfrom
benbenbang:enh/add_extra_option_slackwhoptr
Conversation
benbenbang
changed the title
mik-laj
approved these changes
Jun 19, 2020
kaxil
reviewed
Jun 20, 2020
kaxil
approved these changes
Jun 20, 2020
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Minor comment but LGTM otherwise
potiuk
force-pushed
the
v1-10-test
branch
8 times, most recently
from
f47e81a to
e31761f
Compare
Contributor
Author
Member
|
I have restarted CI, let's see if it passes this time |
Contributor
Author
|
hmmm, it failed randomly... Do you have any thoughts on this @kaxil? |
dimberman
approved these changes
Jun 23, 2020
|
Awesome work, congrats on your first merged pull request! |
potiuk
pushed a commit
that referenced
this pull request
Jun 29, 2020
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.