Restrict changing XCom values from the Webserver#9614
Merged
kaxil merged 3 commits intoapache:masterfrom Jul 1, 2020
Merged
Conversation
Since XCom values can contain pickled data, we would no longer allow editing Xcom values from the UI. We don't allow changing DAG files from the UI, so this brings XComs in line with that
potiuk
reviewed
Jul 1, 2020
airflow/www/views.py
Outdated
| datamodel = AirflowModelView.CustomSQLAInterface(XCom) | ||
|
|
||
| base_permissions = ['can_add', 'can_list', 'can_edit', 'can_delete'] | ||
| base_permissions = ['can_add', 'can_list', 'can_delete'] |
Member
There was a problem hiding this comment.
I think we should remove "can_add" as well? When you restart the task, the xcom is wiped and you will be able to add it then ...
Member
There was a problem hiding this comment.
Yeah, add has the same potential problems as edit
potiuk
approved these changes
Jul 1, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry-picked from 1655fa9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since XCom values can contain pickled data, we would no longer allow editing Xcom values from the UI.
We don't allow changing DAG files from the UI, so this brings XComs in line with that
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.