[Variant] Introduce parquet-variant-json crate
#7862
+818
−782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 3, 2025
| @@ -1,552 +0,0 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
I moved these tests into a mod test next to the relevant code
alamb
commented
Jul 3, 2025
| @@ -1,151 +0,0 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
alamb
commented
Jul 3, 2025
| @@ -1,50 +0,0 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
This example duplicated the doc example on from_json so I removed it entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
serde_jsondependency ofparquet-variant#7845serde_jsonan optional dependency ofparquet-variant#7775Rationale for this change
Now that we have the basic json conversion functionality complete thanks to @harshmotw-db ❤️ ❤️ ❤️ in
I would like to move all the json related code into its own crate to keep the functionality clean and clear
What changes are included in this PR?
parquet-variant-jsoncrate where we can continue to iterateAre these changes tested?
CI
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.